Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about local reveal_url_prefix #844

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Conversation

OliverEvans96
Copy link
Contributor

I noticed that absolute paths do not work since a URL is constructed from the directory, but this was not clear from the documentation. If someone has a better wording, I'll be glad to change it.

Also, this should updated in https://nbconvert.readthedocs.io/en/latest/config_options.html but the 'Edit on Github' button is broken.

I noticed that absolute paths do not work since a URL is constructed from the directory, but this was not clear from the documentation. If someone has a better wording, I'll be glad to change it. 

Also, this should updated in https://nbconvert.readthedocs.io/en/latest/config_options.html but the 'Edit on Github' button is broken.
@minrk minrk added this to the 5.4 milestone Aug 16, 2018
@minrk minrk merged commit ec8c320 into jupyter:master Aug 16, 2018
@minrk
Copy link
Member

minrk commented Aug 16, 2018

Thanks!

@OliverEvans96 OliverEvans96 deleted the patch-1 branch August 16, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants