Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass config to kernel from ExecutePreprocessor for configurable kernels #816

Merged
merged 5 commits into from
Aug 2, 2018

Commits on May 17, 2018

  1. Configuration menu
    Copy the full SHA
    1726d1f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. Move preprocess logic into setup_preprocessor and start_new_kernel

    setup_preprocessor is a contextmanager that handles setting and cleaning
    up attributes needed by the rest of the execution logic (specifically
    self.nb, self.km, self.kc).
    
    start_new_kernel was previously a callback function and is now a
    separate method used inside setup_preprocessor.
    
    This also introduces a dynamic default for the `kernel_name` traitlet
    that checks if self.nb is defined to see if it has a kernel name, and
    otherwise will raise an AttributeError (since that means it is being
    relied upon without any way to know which kernel is to be used.
    mpacer committed May 19, 2018
    Configuration menu
    Copy the full SHA
    c1cb89c View commit details
    Browse the repository at this point in the history
  2. cleans up traitlet stuff

    moved _display_id_map help inside the declaration instead of comment
    
    unified named imports from traitlets
    mpacer committed May 19, 2018
    Configuration menu
    Copy the full SHA
    0de8f30 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2018

  1. Configuration menu
    Copy the full SHA
    d793902 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9611e95 View commit details
    Browse the repository at this point in the history