-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latex ipython template: draw a vertical line left of ipython code #789
Conversation
45cb547
to
ceb8baf
Compare
Thanks, @timhoffm! @tgeorgeux, does this look good to you? |
I like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thank you for doing this @timhoffm !
Can we reconsider? I don't like that this occurs at the The extra line is super out of place in my templates, and I'll have to overwrite this change. |
I also really don't like that the line extends to the extra newline, and that the line is to the left of the prompt and not between the prompt and the code (but I understand that with the implementation that that's not easy). Since this is a stylistic thing, I think it should occur at the level of |
I also just realised that this change will mess with people who use nbconvert to produce reports by hiding the code from the converted document since the lines will again be out of place. |
Just for reference, here's how I'm planning to re-design the LaTeX representation of code cells in |
I'm going to remove the 5.5 milestone on this PR, as we're about to release and there hasn't been a resolution to concerns raised sufficient to warrant merging, changing, or closing the PR imho. |
There is an IMHO more promising approach in #992. |
Closing in favor of #992. |
This PR adds vertical lines to the left of code blocks in Latex output. The lines are colored in the respective input/output color.
IMHO this greatly improves readability as it's easier to distinguish between code and text and between input and output. Also it helps to see which code was originally grouped in the cells.
See the following example: