Use defusedxml to parse potentially untrusted XML #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good :) Do you have an estimated release date for 5.4 ? |
|
Thanks. We're working towards a new release, but it may be a few weeks. |
|
Gitflow and Hubflow have 'hotfix' branches off of the release branch for exactly this problem. You can branch off the release branch, cherry pick the security patch, bump the version, merge back to the release branch, and cut a release without having to release all of the pending new features on the develop branch. https://datasift.github.io/gitflow/GitFlowForGitHub.html#9-creating-hotfixes From https://datasift.github.io/gitflow/IntroducingGitFlow.html : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untrusted XML data can cause havoc with unprepared parsers. I'm not sure whether our default templates are vulnerable to this, but it makes sense for the filters to be defensive in handling it.
Closes gh-706