Specify default template files with extension #639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make issues like ipython/ipython#10731 less likely. At present, if you have a file in the working directory called
python
orrst
orarticle
(and so on) with no extension, nbconvert will try to use that as the template. Honestly, I'm surprised this hasn't come up more.With this change, it will only look for the default template files with their extension. So you can still override it with a file called
python.tpl
, for instance. But that's less likely to be there accidentally thanpython
.