Add remove regex default to TemplateExporter, don't remove cells with outputs but no source #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| Preprocessing to apply to each notebook. See base.py for details. | ||
| Checks that a cell matches the pattern and that (if a code cell) |
There was a problem hiding this comment.
The comment here doesn't quite match the code below: The function checks that the cell does not match the pattern or is a code cell with output.
As an aside, are there any other cell types that can have output? We might just be able to check not pattern.match(cell.source) or cell.get('outputs'). Then cell.get('outputs') will evaluate to false if the key doesn't exist or the list is empty.
There was a problem hiding this comment.
No other cell types have outputs, so we should be in the clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #615.
This enables RegexRemovePreprocessor in the TemplateExporter.
It also changes its behaviour to not remove cells that do have output even if they match the regular expression (which, by default, is the empty string).
@tillahoffmann is this consistent with your original intended use of this preprocessor (keeping in mind that tag-based input filtering should also be possible soon)?