-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt playwright #2013
Adopt playwright #2013
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The workaround commit is to fix the tests when the chromium browser is not available. This test worked only if pytest do not capture the output ( |
I have no clue on this test failure too (occurs locally also): Don't know why it used to pass as nbconvert/nbconvert/exporters/exporter.py Lines 203 to 205 in 50b86f8
but nbconvert/nbconvert/exporters/html.py Lines 227 to 229 in 50b86f8
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Since it fails with python<3.8, I wonder if we should drop support to Python 3.7 (easy fix). |
for more information, see https://pre-commit.ci
I'm removing Python 3.7 support in #2008. I'm updating this branch to pick up those changes. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Thanks @blink1073 for fixing the tests |
handleSIGINT=False, handleSIGTERM=False, handleSIGHUP=False, args=args | ||
) | ||
page = await browser.newPage() | ||
await page.emulateMedia("print") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that that option was lost in the upgrade process. As the option is available in playwright, I guess it will be better to restore it to increase backward compatibility.
cc @brichet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fcollonval. I opened #2022
Since pyppeteer is now unmaintained we should adopt playwright instead.