Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
In #1643, the
WidgetsDataTypeFilter
is updated to filter out the widgets without the state. To make it works,WidgetsDataTypeFilter
needs to have access to the notebook's metadata which is only available after instantiating the filter itself. This situation leads to a widget rendering issue ifnbconvert
needs to execute the notebook before converting it.Code changes
This PR updates the logic of getting the notebook's metadata inside
WidgetsDataTypeFilter
and adds some tests for the case of executing the notebook before converting.