Allow users to customize mathjax URLs #1609
Conversation
|
@SylvainCorlay could i get a review on this too please? |
|
@bsyouness - we just fixed the CI checks. Can you rebase or merge in main like you did above to get the CI checks working again? |
…o customizeajaxurl
This reverts commit 14e8f6d.
|
@jasongrout thanks for the review and for walking me through the comments! I made the changes we talked about. |
|
@bsyouness I noticed that your git author email does not match your github account email, which causes github to not credit them to you. You may want to either change the author email for these commits or add that address to your github account to be properly credited before the PR gets in. |
|
Since Youness and I both work at the same place, I'd prefer if someone else (@MSeal?) looks at this too and does the merge. I'm also happy to merge it if someone else approves. |
We're running into an issue where we'd like to customize the mathjax URL used by nbconvert but we're unable to do so easily. This PR uses the same methodology to make the mathjax customizable as is used to load the js scripts in the require.js jinja templates. This allows users to circumvent the use of CDNs to pull the mathjax dependencies.