add pip to docs envt #1571
Merged
add pip to docs envt #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok @yuvipanda so this pip fix makes the docs build fast! yay! Warning, treated as error:
/root/checkout/nbconvert/exporters/exporter.py:docstring of nbconvert.exporters.exporter.Exporter.register_preprocessor:8:more than one target found for 'any' cross-reference 'Preprocessor': could be :py:class:`nbconvert.preprocessors.Preprocessor` or :py:class:`nbconvert.preprocessors.base.Preprocessor`But this docstring issue is still present. i am not working tomorrow so i won't respond again until next monday. Feel free to edit this PR or just let me k now how to adjust that docstring and i can address it this weekend or monday! :) |
|
This is already an improvement, @lwasser - without this there was hundreds of lines of output in the docs ci :) So I'm going to merge this now, and we can take another stab at the remaining issue when you come back :) Have a good weekend! |
|
excellent! glad it was helpful. i'll dig a bit more into that docstring item one evening this week! |
|
Thanks, @lwasser :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the issue where CI hangs when building docs due to not being able to find pip correctly - note that the this builds upon issues discovered in #1567