Feature: support static widgets in Reveal.js slides #1553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the embedding of widget state in rendered notebooks using the
SlidesExporter
with the defaultreveal
template. This has been implemented by adding a call tosuper()
in the footer block, which calls thelab/base.html.j2
implementation.I don't know whether this is the preferred style of nbconvert. Looking at
base.html.j2
andindex.html.j2
, it seems like there is animplementation
(base) vsclient
(index) separation. If this is the case, perhaps a more robust (although breaking) change would be to rename thefooter
block inbase.html.j2
to something likeembed_widget_state
:nbconvert/share/jupyter/nbconvert/templates/lab/base.html.j2
Lines 262 to 270 in e49b9a8