Allow child templates to override mathjax #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, mathjax is loaded synchronously in <head>, causing render to block before moving forward. This is problematic, especially since most notebooks don't actually have any math to render. This PR allows mathjax to be customized by child templates that inherit from lab or classic. They can make it empty, and load mathjax how they want - in the footer, only if there is any math to be rendered, etc. This should cause no difference in structure for the default templates themselves.
yuvipanda
requested review from
maartenbreddels and
SylvainCorlay
and removed request for
maartenbreddels
Closed
|
This looks good to me. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, mathjax is loaded synchronously in , causing
render to block before moving forward. This is problematic,
especially since most notebooks don't actually have any
math to render.
This PR allows mathjax to be customized by child templates
that inherit from lab or classic. They can make it empty,
and load mathjax how they want - in the footer, only if
there is any math to be rendered, etc.
This should cause no difference in structure for the
default templates themselves.