Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1507: broken command line option --CSSHTMLHeaderPreprocessor.style= #1548

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

finale80
Copy link
Contributor

With the upgrade to version 6.x the pygment related command line option --CSSHTMLHeaderPreprocessor.style= is broken as reported by this open issue #1507

I'm testing simply converting a notebook to html. For examples

jupyter nbconvert --HTMLExporter.theme=dark --to html notebook.ipynb --CSSHTMLHeaderPreprocessor.style=monokai

Looks like that exporters' config are not propagated to the preprocessors (?)
The function I'm changing does not appear in version 5.x so I assume there are design decisions underneath

The fix is simple, but there might be implications that I miss

@MSeal
Copy link
Contributor

MSeal commented Jun 7, 2021

Thanks for the improvement. I don't see an issue with the change and it seems helpful so I'll merge ahead of the alpha release here

@MSeal
Copy link
Contributor

MSeal commented Jun 7, 2021

Tests pass locally after merging in main, going to merge ignore CI

@MSeal MSeal merged commit 7a0637d into jupyter:main Jun 7, 2021
@MSeal MSeal added this to the 6.1 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants