fix issue 1507: broken command line option --CSSHTMLHeaderPreprocessor.style= #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for the improvement. I don't see an issue with the change and it seems helpful so I'll merge ahead of the alpha release here |
|
Tests pass locally after merging in main, going to merge ignore CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade to version 6.x the pygment related command line option --CSSHTMLHeaderPreprocessor.style= is broken as reported by this open issue #1507
I'm testing simply converting a notebook to html. For examples
Looks like that exporters' config are not propagated to the preprocessors (?)
The function I'm changing does not appear in version 5.x so I assume there are design decisions underneath
The fix is simple, but there might be implications that I miss