Make pagination configurable in webpdf #1513
Conversation
IMO, webpdf should be a 'drop-in' replacement for the LaTeX PDF generation as much as possible. The default should be to paginate, and it can be turned off by config if needed. Ref #1464
yuvipanda
changed the title
|
@SylvainCorlay do you remember what the driving use case for turning off pagination in #1402 was? |
|
Hey @yuvipanda thanks for this! When we did #1402, there was no release including webpdf yet, and I was having issues with pagination, so I probably decided to remove it together before the release. |
|
It does not seem you are actually defaulting to pagination (in contrary to the PR description). Although I am not sure we should default to pagination (for backward compat). What do you think? |
|
@SylvainCorlay ah, thanks for that catch. Made it the default now. It looks like pagination was the default until 6.0.4, when single page became the default. IMO, it's ok to revert it in another patch release. webpdf is also such a new convertor, I think it's ok. |
|
LGTM. The issue in the tests looks like a problem with quotes in a string. |
|
@SylvainCorlay yeah, that's unrelated - I've #1512 to try and fix that. |
PDF generator as much as possible.
Ref #1464