Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change template_path to template_paths in documentation examples #1374

Merged
merged 2 commits into from
Sep 12, 2020

Conversation

willingc
Copy link
Member

Closes #1371

@willingc willingc requested a review from MSeal September 12, 2020 05:15
@willingc willingc self-assigned this Sep 12, 2020
@@ -1,5 +1,7 @@
"""
this script builds html files with either classic or classic_clone templates

Note: nbconvert 6.1 changed ``template_path`` to ``template_paths``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically 6.0 changed it, but this is fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that I'm going to go back and change this ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I didn't want to get in the way of improvements merging :)

@MSeal
Copy link
Contributor

MSeal commented Sep 12, 2020

Thanks @willingc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template_path still appearing in docs, despite rename
2 participants