Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inheritance breaking clear-output option #1312

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

MSeal
Copy link
Contributor

@MSeal MSeal commented Jul 2, 2020

Fixes #822 -- the issue is caused by the Jupyter application class upstream matching the TagRemovePreprocessor subclass of ClearOutputPreprocessor as the valid config when set to ClearOutputPreprocessor. There wasn't a good reason for the inheritance there anyway. I added a test to confirm behavior outside of manual testing.

@SylvainCorlay SylvainCorlay merged commit c929426 into jupyter:master Jul 2, 2020
@MSeal MSeal added this to the 6.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--clear-output flag is broken
2 participants