Escape HTML characters in latex output strings #1278
Conversation
Without this change, latex like `\left<content\right>` renders as a `<content\right>` html tag, which mathjax can't handle.
eric-wieser
changed the title
|
CI failure look unrelated. |
|
Restarting CI just to be sure. |
|
CI docs build I'm going to try fixing today, don't worry about that one |
There was a problem hiding this comment.
LGTM in testing, though it needs to be added to the other places with the output.data['text/latex'] (namely the lab template) if you don't mind adding those.
Would you mind if I copy that algebra notebook into our examples to test against? It has a nice set of latex patterns all in one.
|
Coping the notebook is fine, but it depends on I guess if you don't rerun the notebook then it does not matter. |
|
Since I'm not really familiar with the structure of this project, would it be ok if I left the lab notebook and other HTML pages to you? |
|
Sure, I can push into the PR where else it's obvious the same change needs applying when I get a chance. |
Without this change, latex like
\left<content\right>renders as a<content\right>html tag, which mathjax can't handle.See https://nbviewer.jupyter.org/urls/galgebra--417.org.readthedocs.build/en/417/tutorials/algebra.ipynb#More-examples for an example of this failing.
This is like #514, but for cell outputs.