Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve template whitespacing #1076

Merged
merged 5 commits into from
Aug 6, 2019
Merged

Improve template whitespacing #1076

merged 5 commits into from
Aug 6, 2019

Conversation

t-makaro
Copy link
Contributor

@t-makaro t-makaro commented Jul 30, 2019

Fixes #1059, and fixes #376. I chose this method because I noticed that the markdown exporter has the same issue which is problematic for people that need a title as the first thing in a markdown export.

I also made some improves to enhance readability of the latex exporter, but nothing will render differently due to this.

I also added a default documentclass to the base.tplx so that all of the style_*.tplx files can now be used on there own. This technically makes article.tplx redundant.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add a test for setting strip_preceding_newlines? Do you envision that field needing to ever be False?

@t-makaro
Copy link
Contributor Author

I honestly can't envision strip_preceding_newlines ever needing to be false, but I thought that I'd add some way to disable it in case someone needs the old behaviour. In the interest of not adding excess config, it would probably be better to remove that check. If anyone ever needs it, we can add it later (it would also be possible to re-add the space in an inherited exporter with some work).

@t-makaro t-makaro added this to the 5.6 milestone Jul 31, 2019
@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowing shebang #! when converting to script Markdown convert adds empty row as first row
3 participants