Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require mock only on Python 2 #1060

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Require mock only on Python 2 #1060

merged 1 commit into from
Jul 5, 2019

Conversation

kapsh
Copy link
Contributor

@kapsh kapsh commented Jul 3, 2019

Only usage of mock is inside "except ImportError" meant for running tests
under Python 2. So there is no need to install it for any Python 3.

Only usage of mock is inside "except ImportError" meant for running tests
under Python 2. So there is no need to install it for any Python 3.
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the the change!

@MSeal MSeal merged commit 5714fdb into jupyter:master Jul 5, 2019
@MSeal MSeal added this to the 5.6 milestone Jul 30, 2019
@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants