Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp configuration documentation #1048

Merged
merged 5 commits into from
Jun 14, 2019
Merged

Revamp configuration documentation #1048

merged 5 commits into from
Jun 14, 2019

Conversation

t-makaro
Copy link
Contributor

@t-makaro t-makaro commented Jun 13, 2019

Documents flags and aliases. Adds sections for different configuration options. (App, Exporter, Preprocessor, PostProcessor, Writer, Other). Fixes #1047. Added a few inheritance diagrams, and an explanation of how configuration options inherit.

@t-makaro t-makaro requested a review from MSeal June 13, 2019 02:38
docs/source/conf.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change suggested. Thanks for making some cleanups on this.

Co-Authored-By: Matthew Seal <mseal007@gmail.com>
@t-makaro t-makaro requested a review from MSeal June 14, 2019 04:45
@t-makaro
Copy link
Contributor Author

I made that slight change. I believe this is ready for merging.

@MSeal MSeal merged commit bf1850a into jupyter:master Jun 14, 2019
@t-makaro t-makaro mentioned this pull request Jun 15, 2019
@willingc
Copy link
Member

Nice job @t-makaro. Great to see you contributing :D

@MSeal MSeal added this to the 5.6 milestone Jul 30, 2019
@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building documention on windows doesn't include config_option.rst
4 participants