simplify the function signature for preprocess() #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When [executing notebooks using the Python API interface](https://nbconvert.readthedocs.io/en/latest/execute_api.html#executing-notebooks-using-the-python-api-interface), I noticed that providing the `resources` to `preprocess()` is required, even if the user doesn't intend for anything to be overridden. This change makes that argument optional.
|
That's a handy change. Asking for @mpacer to take a look to make sure there wouldn't be any unintended consequences that I am not thinking of. |
|
Also there's a test issue in master atm we'll get fixed so the builds start passing again. |
|
@MSeal This appears in nbconvert latest docs but not in version 5.5.0 (i.e. latest one when downloading nbconvert locally) - I wonder why? I need to use it. Thanks! |
|
@jaladh-singhal 5.6.0 release will include this change. You can track the release progress here: #1052 |
|
OK, thanks:+1: |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change: When executing notebooks using the Python API interface, I noticed that providing the
resourcestopreprocess()is required, even if the user doesn't intend for anything to be overridden. This change makes that argument optional.Thanks!