-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latex improvements #1024
Latex improvements #1024
Conversation
Also: Spacing between cells: This applies to text before/after cells too. CC @mgeier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, but I have a hard to evaluating for potential latex cornercases. What's the risk factor in your opinion? Should we get another more latex knowledgeable review or do you feel pretty confident this is the right approach? If it's the later I can merge this now.
I believe it is the right approach. The All of the options in the original My bigger worry is if someone made a template that used |
Ahh the We could keep the backwards compatibility for the next patch release but note in the release notes that we'll remove that compatibility in 6.x? |
@MSeal I managed to squeeze in one more fix. It's good to merge once tests pass. |
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1 |
The follow up PR to #992.
usepackage{titling})
)\tcbset{nobeforeafter}
)\usepackage{parskip}
)\setkeys
option to fix this, since it had a side effect of shrinkingadjustimage
boxes. However, by adding theExport
flag to the adjustbox package it exports a new version ofincludegraphics
that still allows use of all the keys whilst still setting a maximum size for images.Before:
After: