Fix backwards incompatibility with markdown2html #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a reasonable safeguard in the code. |
|
There's a few items floating around for 5.5.1 or possible a 5.6 release in the not-too-distance future so it shouldn't linger outside a release for too long. |
|
Great, thanks! |
|
Hi Jessica, sorry for breaking that! |
|
No problem, it's part of the process 😄 |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to
html.py's handling ofmarkdown2htmlalso breaks nbgrader, which uses themarkdown2htmlfilter. The original filter only assumes the input is source code, not necessarily a cell, but the new version of the filter in this file assumes the context includes a'cell'field. This isn't the case for the way the filter is being used by nbgrader, but this change alleviates the problem by returning an empty dictionary by default for the cell contents.Related to #1007