Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed newlines from clear notebook test. Refactored test_run_notebooks #1015

Merged
merged 3 commits into from
May 6, 2019

Conversation

MSeal
Copy link
Contributor

@MSeal MSeal commented May 5, 2019

Fixes the periodic test failures where the ipython kernel sometimes flushed stdout before the newline was printed from the print function.

Also refactored test_execute.py so that the test_run_notebooks test could be parameterized and better report what notebook failed in test_run_all_notebooks. The test code changes outside of test_run_all_notebooks is just static functions moving outside the test class -- not functionality was changed there.

@MSeal MSeal requested review from ivanov and mpacer May 5, 2019 18:23
Copy link
Member

@ivanov ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring looks good, so long as the tests pass

@MSeal MSeal merged commit b625b10 into jupyter:master May 6, 2019
@MSeal MSeal deleted the fix_random_notebook_test_failure branch May 6, 2019 19:14
@MSeal MSeal restored the fix_random_notebook_test_failure branch May 6, 2019 19:14
@MSeal MSeal added this to the 5.6 milestone Jul 30, 2019
@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants