Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require mock for tests #1011

Merged
merged 1 commit into from
May 2, 2019
Merged

Require mock for tests #1011

merged 1 commit into from
May 2, 2019

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented May 2, 2019

______ ERROR collecting nbconvert/preprocessors/tests/test_execute.py ______
ImportError while importing test module '.../jupyter/nbconvert/nbconvert/preprocessors/tests/test_execute.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
nbconvert/preprocessors/tests/test_execute.py:26: in <module>
    from mock import MagicMock
E   ModuleNotFoundError: No module named 'mock'

______ ERROR collecting nbconvert/preprocessors/tests/test_execute.py ______
ImportError while importing test module '.../jupyter/nbconvert/nbconvert/preprocessors/tests/test_execute.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
nbconvert/preprocessors/tests/test_execute.py:26: in <module>
    from mock import MagicMock
E   ModuleNotFoundError: No module named 'mock'
@MSeal
Copy link
Contributor

MSeal commented May 2, 2019

Thanks!

@MSeal MSeal merged commit 1ba6dcb into jupyter:master May 2, 2019
@MSeal MSeal added this to the 5.6 milestone Jul 30, 2019
@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1

@hroncok hroncok deleted the mock branch August 9, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants