Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pdf exporter inheriting the wrong file extension #1000

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Fix pdf exporter inheriting the wrong file extension #1000

merged 3 commits into from
Apr 25, 2019

Conversation

t-makaro
Copy link
Contributor

Fixes #999

@t-makaro t-makaro mentioned this pull request Apr 25, 2019
Merged
@t-makaro
Copy link
Contributor Author

Tests are passing, but I think this change makes the latex exporter write the .tex file as a .pdf file instead (which the latex compiler reads as text just fine).

@MSeal
Copy link
Contributor

MSeal commented Apr 25, 2019

Yep. Tested that the conversion was ok post change.

@MSeal MSeal added this to the 5.5 milestone Apr 25, 2019
@MSeal MSeal merged commit 55e300e into jupyter:master Apr 25, 2019
@t-makaro t-makaro deleted the extension branch April 25, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

Pdf exporter thinks it outputs to .tex
2 participants
@t-makaro @MSeal