Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets not rendered when notebook is output/printed, garbled when widget state is saved #1562

Closed
rabejens opened this issue Apr 30, 2021 · 2 comments · Fixed by #1665
Closed

Widgets not rendered when notebook is output/printed, garbled when widget state is saved #1562

rabejens opened this issue Apr 30, 2021 · 2 comments · Fixed by #1665

Comments

@rabejens
Copy link

I am running Jupyter with Jupyterlab and Sparkmagic to use Apache Spark through Livy. When I output results as a table or plot, the widgets are either not shown at all or the output is garbled.

If "Save widget state automatically" is enabled, the output is garbled, if not, it is missing

Run the attached notebook and open the print preview

Widget.ipynb.txt

Without saving widget state
Without saving widget state

With saving widget state
With saving widget state

Nbconvert version: 6.0.7
@maartenbreddels
Copy link
Collaborator

cc @SylvainCorlay
This is similar to voila-dashboards/voila#804 where we could simply not embed the json, but the solution should be to base64 encode it to avoid the HTML inside the json to be interpreted by the browser I think.

@maartenbreddels
Copy link
Collaborator

Related #802

maartenbreddels added a commit to maartenbreddels/nbconvert that referenced this issue Oct 27, 2021
@maartenbreddels
fix: avoid closing the script tag early by escaping a forward slash
0252cfa 
Closes jupyter#1562
Closes jupyter#802
Related jupyter#804
@maartenbreddels maartenbreddels mentioned this issue Oct 27, 2021
Merged
SylvainCorlay pushed a commit that referenced this issue Oct 27, 2021
@maartenbreddels
fix: avoid closing the script tag early by escaping a forward slash (#…
11ea593 
…1665)

Closes #1562
Closes #802
Related #804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid closing the script tag early by escaping a forward slash maartenbreddels/nbconvert
2 participants
@maartenbreddels @rabejens