Skip to content

Commit

Permalink
Merge pull request #499 from takluyver/i495
Browse files Browse the repository at this point in the history
Don't import jupyter_client unless we're executing the notebook
  • Loading branch information
Michael Pacer authored Dec 22, 2016
2 parents 5759515 + ca02284 commit d7c996c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions nbconvert/preprocessors/execute.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
from .base import Preprocessor
from ..utils.exceptions import ConversionException
from traitlets import Integer
from jupyter_client.manager import KernelManager


class CellExecutionError(ConversionException):
Expand Down Expand Up @@ -139,7 +138,7 @@ class ExecutePreprocessor(Preprocessor):
).tag(config=True)

kernel_manager_class = Type(
default_value=KernelManager,
default_value='jupyter_client.manager.KernelManager',
config=True,
help='The kernel manager class to use.'
)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def run(self):
extras_require = setuptools_args['extras_require'] = {
# FIXME: tests still require nose for some utility calls,
# but we are running with pytest
'test': ['pytest', 'pytest-cov', 'nose', 'ipykernel'],
'test': ['pytest', 'pytest-cov', 'nose', 'ipykernel', 'jupyter_client'],
'serve': ['tornado>=4.0'],
'execute': ['jupyter_client'],
}
Expand Down

0 comments on commit d7c996c

Please sign in to comment.