Add the notebook 6.4.x tests, docs and companion files (with git history) #94

echarles · 2022-04-28T06:22:46Z

This is a follow-up of #93

This PR pulls the https://github.com/jupyter/notebook history of the 6.4.x branch for various folders and files (see details here after). After merging this PR, nbclassic will continue to work as before and manual PR will be needed to enrol the newly merge assets, tests... As soon as this gets merged, I will start working on the new PR.

# This is how the commits have been selected.
git clone https://github.com/jupyter/notebook.git --branch 6.4.x
cd notebook
# Use https://github.com/newren/git-filter-repo
git filter-repo \
  --path .github/workflows/docs.yml \
  --path .github/workflows/js.yml \
  --path .github/workflows/selenium.yml \
  --path docs \
  --path docs-translations \
  --path git-hooks \
  --path notebook/templates \
  --path notebook/tests/_testdata \
  --path notebook/tests/base \
  --path notebook/tests/mockextension \
  --path notebook/tests/notebook \
  --path notebook/tests/selenium \
  --path notebook/tests/services \
  --path notebook/tests/launchnotebook.py \
  --path notebook/tests/README.md \
  --path notebook/tests/util.js \
  --path notebook/tests/launchnotebook.py \
  --path notebook/jstest.py \
  --path tools \
  --path .babelrc \
  --path .bowerrc \
  --path .eslintignore \
  --path .eslintrc.json \
  --path bower.json \
  --path jupyter-notebook.desktop \
  --path jupyter.svg \
  --path readthedocs.yml \
  --path webpack.config.js

Use separately packaged sphinxcontrib_github_alt

…al name

Add explicit instruction for online documentation pages

… not required

Converted clipboard js to selenium and renamed undelete.py

Convert dualmode_cellmode to selenium

Previously know as validate_notebook_mode changed name to validate_dualmode_mode to represent better the method. Added a docstring. Removed the handling of index being None.

…le_js_to_selenium Migrate multiselect toggle test to selenium

Added more information about what the checks are

Removed parentheses Changed '==' for 'is' on None

Changed asserts for returns Changed how the function is called on edit mode check

Moved 'assert mode == keyboard_mode' ouside the branches. This means that if a unknown mode comes its gonna get catched by the assert and never gona get to the else statement. For this, the else stament moved to before the assert, caching the mode error before the assert.

Changed 'for mode in cells_mode' for 'for i, mode in enumerate(cells_mode)' Removed the manual 'i' increment and declaration.

Convert dualmode_execute, dualmode_clipboard & dualmode_markdown to selenium

fix duplicates in download as menu

Update Working With Markdown Cells.ipynb

Switch webpack to production mode

Fix syntax highlight

Pin nbsphinx to 0.8.6, clean up orphaned resources

DOC: Fix nbsphinx settings

Fully revert the pinning of nbsphinx to 0.8.6

This is a fix for jupyter/notebook#6164 `nest_asyncio` must be applied before any async tasks have been created otherwise there could be tasks queued that are unpatched, and thus do not respect nested loops. An example of an unpatched task can be seen in the original issue: ``` <Task pending coro=<HTTP1ServerConnection._server_request_loop() running at /apps/python3/lib/python3.7/site-packages/tornado/http1connection.py:823> ``` which originates from Tornado. A similar issue was reported in `nest-asyncio`: erdewit/nest_asyncio#22 where the solution is to call `apply` on import so that unpatched tasks do not get created.

Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: maliubiao <maliubiao@gmail.com> Co-authored-by: Maxim Martynov <martinov_m_s_@mail.ru> Co-authored-by: Niyas Sait <niyas.sait@linaro.org> Co-authored-by: Jiaqi <jiaqi@creditninja.com> Co-authored-by: Ben Greiner <code@bnavigator.de> Co-authored-by: David Leen <dleen@netflix.com> Co-authored-by: Kevin Bates <kbates4@gmail.com> Co-authored-by: Steven Silvester <steven.silvester@gmail.com>

…rs (#6320)

…by phantomjs

Update further to ipykernel comm refactoring

echarles · 2022-04-28T06:24:24Z

@Zsailer While doing the next manual PR, it may be possible I realize that I have missed some files. In that case, I will create similar PR to pull the history.

echarles · 2022-04-29T06:14:51Z

Thx @Zsailer

takluyver and others added 30 commits April 4, 2019 08:14

Merge pull request #4536 from takluyver/sphinxext-github-out

9148f04

Use separately packaged sphinxcontrib_github_alt

changelog for 5.7.8

8a00d8b

Converted clipboard js to selenium and rename undeleted to convention…

fe8e39b

…al name

fix duplicates in download as meny

cca9ce3

Update Working With Markdown Cells.ipynb

38b4ce8

Add explicit instruction for online documentation pages

Add some code style improvements by not using list comprehension when…

ad4e953

… not required

Merge pull request #4563 from emiliotl/convert_clipboard_js_to_selenium

4a96615

Converted clipboard js to selenium and renamed undelete.py

Convert dualmode_cellmode to selenium

74399bb

Add alt command, gets, and validate_notebook_state

dd05413

Convert dualmode_clipboard to selenium

8942e3e

Convert dualmode_execute to selenium

6623c91

Remove unused import & refactor

3b702ba

Convert dualmode_markdown to selenium

833a200

Convert multiselect_toggle to selenium

2d2c0f8

Remove multiselect_toggle js

037c490

Merge pull request #4608 from LuisARodr/dualmode_tests

7c8c8c0

Convert dualmode_cellmode to selenium

Resolve notebook len duplicate method

1370ae7

Refactor validate_dualmode_mode

d3be3ab

Previously know as validate_notebook_mode changed name to validate_dualmode_mode to represent better the method. Added a docstring. Removed the handling of index being None.

Modified 'scrolling enabled' test assert

145e085

Merge pull request #4617 from TeresaPartidaS/convert_multiselect_togg…

4ff1549

…le_js_to_selenium Migrate multiselect toggle test to selenium

Update docstring

f05d0c2

Added more information about what the checks are

Refactor of ifs

b3ad35c

Removed parentheses Changed '==' for 'is' on None

Solve insonsistensy on is_focused_on

07482d4

Changed asserts for returns Changed how the function is called on edit mode check

Change assert for Exception

9945ded

Give space to inline comments

76a5646

Refactor for

5c9c518

Changed 'for mode in cells_mode' for 'for i, mode in enumerate(cells_mode)' Removed the manual 'i' increment and declaration.

Merge pull request #4615 from LuisARodr/dualmode_execute

2010dab

Convert dualmode_execute, dualmode_clipboard & dualmode_markdown to selenium

Merge pull request #4588 from t-makaro/downloadas

f01ecf4

fix duplicates in download as menu

Merge pull request #4591 from dalanicolai/patch-1

a0605be

Update Working With Markdown Cells.ipynb

Zsailer and others added 23 commits August 10, 2021 15:32

Merge pull request #6131 from afshin/webpack-production

6668c66

Switch webpack to production mode

Merge pull request #6128 from massongit/patch-1

8568be5

Fix syntax highlight

Pin nbsphinx to 0.8.6, clean up orphaned resources

76a833b

workaround for webpack crypto (#6197)

d930bf3

Merge pull request #6194 from kevin-bates/fix-docs

a01aeba

Pin nbsphinx to 0.8.6, clean up orphaned resources

DOC: remove unnecessary (and wrong) source_suffix setting

7ed1080

DOC: unpin nbsphinx version

43eb6c7

Merge pull request #6200 from mgeier/doc-nbsphinx-fix

4c11236

DOC: Fix nbsphinx settings

Fully revert the pinning of nbsphinx to 0.8.6

085f214

Merge pull request #6201 from kevin-bates/revert-nbsphinx-0.8.6

bbbb495

Fully revert the pinning of nbsphinx to 0.8.6

Update links and fix check-release (#6310)

24a52ed

Use place-hold.it instead of plaecehold.it to create image placeholde…

6185b6b

…rs (#6320)

Fix #6256 : migrate to python 3.7+ (#6260)

296eeba

temporary workaround to fix js-tests related to sanitizer js loading …

5e12d75

…by phantomjs

install workaround before installing with pip

3dee67b

Update further to ipykernel comm refatoring

15e7bc0

more fixes for ipykernel refactoring

154544c

revert bad fix for comms rst

73efe17

Merge pull request #6358 from datalayer-externals/fix/comm-refactor

6456572

Update further to ipykernel comm refactoring

Rename notebook to nbclassic

a9638b9

Merge branch 'main' into nbclassic/6.4.x-round-2

1362f76

echarles added the maintenance label Apr 28, 2022

echarles requested a review from Zsailer April 28, 2022 06:29

Zsailer approved these changes Apr 28, 2022

View reviewed changes

Zsailer merged commit ca73fca into jupyter:main Apr 28, 2022

echarles mentioned this pull request May 4, 2022

nbclassic to use its own static assets #96

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the notebook 6.4.x tests, docs and companion files (with git history) #94

Add the notebook 6.4.x tests, docs and companion files (with git history) #94

echarles commented Apr 28, 2022

echarles commented Apr 28, 2022

echarles commented Apr 29, 2022

Add the notebook 6.4.x tests, docs and companion files (with git history) #94

Add the notebook 6.4.x tests, docs and companion files (with git history) #94

Conversation

echarles commented Apr 28, 2022

echarles commented Apr 28, 2022

echarles commented Apr 29, 2022