-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the notebook 6.4.x tests, docs and companion files (with git history) #94
Merged
Zsailer
merged 1,601 commits into
jupyter:main
from
datalayer-externals:nbclassic/6.4.x-round-2
Apr 28, 2022
Merged
Add the notebook 6.4.x tests, docs and companion files (with git history) #94
Zsailer
merged 1,601 commits into
jupyter:main
from
datalayer-externals:nbclassic/6.4.x-round-2
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use separately packaged sphinxcontrib_github_alt
Add explicit instruction for online documentation pages
Converted clipboard js to selenium and renamed undelete.py
Convert dualmode_cellmode to selenium
Previously know as validate_notebook_mode changed name to validate_dualmode_mode to represent better the method. Added a docstring. Removed the handling of index being None.
…le_js_to_selenium Migrate multiselect toggle test to selenium
Added more information about what the checks are
Removed parentheses Changed '==' for 'is' on None
Changed asserts for returns Changed how the function is called on edit mode check
Moved 'assert mode == keyboard_mode' ouside the branches. This means that if a unknown mode comes its gonna get catched by the assert and never gona get to the else statement. For this, the else stament moved to before the assert, caching the mode error before the assert.
Changed 'for mode in cells_mode' for 'for i, mode in enumerate(cells_mode)' Removed the manual 'i' increment and declaration.
Convert dualmode_execute, dualmode_clipboard & dualmode_markdown to selenium
fix duplicates in download as menu
Update Working With Markdown Cells.ipynb
Switch webpack to production mode
Fix syntax highlight
Pin nbsphinx to 0.8.6, clean up orphaned resources
DOC: Fix nbsphinx settings
Fully revert the pinning of nbsphinx to 0.8.6
This is a fix for jupyter/notebook#6164 `nest_asyncio` must be applied before any async tasks have been created otherwise there could be tasks queued that are unpatched, and thus do not respect nested loops. An example of an unpatched task can be seen in the original issue: ``` <Task pending coro=<HTTP1ServerConnection._server_request_loop() running at /apps/python3/lib/python3.7/site-packages/tornado/http1connection.py:823> ``` which originates from Tornado. A similar issue was reported in `nest-asyncio`: erdewit/nest_asyncio#22 where the solution is to call `apply` on import so that unpatched tasks do not get created.
Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: maliubiao <maliubiao@gmail.com> Co-authored-by: Maxim Martynov <martinov_m_s_@mail.ru> Co-authored-by: Niyas Sait <niyas.sait@linaro.org> Co-authored-by: Jiaqi <jiaqi@creditninja.com> Co-authored-by: Ben Greiner <code@bnavigator.de> Co-authored-by: David Leen <dleen@netflix.com> Co-authored-by: Kevin Bates <kbates4@gmail.com> Co-authored-by: Steven Silvester <steven.silvester@gmail.com>
Update further to ipykernel comm refactoring
@Zsailer While doing the next manual PR, it may be possible I realize that I have missed some files. In that case, I will create similar PR to pull the history. |
Zsailer
approved these changes
Apr 28, 2022
Thx @Zsailer |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #93
This PR pulls the https://github.com/jupyter/notebook history of the
6.4.x
branch for various folders and files (see details here after). After merging this PR, nbclassic will continue to work as before and manual PR will be needed to enrol the newly merge assets, tests... As soon as this gets merged, I will start working on the new PR.