ensure extension name is passed to TerminalHandler #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server app patches-in extension name to mixin handlers on self.handlers, but these are not on self.handlers anymore.
|
I'm not 100% sure if there's a better way (e.g. keeping everything in self.handlers so that the parent patches still happen), but this works. |
Zsailer
approved these changes
Dec 3, 2021
|
Thanks, @minrk. This looks good for now. |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/nbclassic-terminal-throws-error/12224/2 |
|
Hello, has this been released yet? I'm running |
|
Just released this morning, v0.3.5. |
|
Thanks @Zsailer 👊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server app patches-in extension name to mixin handlers on self.handlers, but these are not on self.handlers anymore.
As a result, terminals pages cannot be accessed after #63