Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use parsed notebook.version_info, not private notebook._version with string comparison
It's never save to compare version strings as pure strings - they must be parsed first (this functionality has unfortunately been removed from the standard library, but
packaging.version
is the de facto standard now), or better yet use already-parsed version_info if/when provided. The code as-is would take the wrong branch if/when notebook 10 arrived.