optimize size and time using "--no-cache-dir" #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Jul 27, 2020
There was a problem hiding this comment.
@Rajpratik71 - thank you for the contribution - this looks good. As you can see from my comments, you've stumbled upon some very out of date code and we should go ahead and take the opportunity to make the appropriate updates. Thank you.
| @@ -3,7 +3,7 @@ | |||
| FROM jupyter/all-spark-notebook:dbb9c7b50531 | |||
|
|
|||
| # Install Kernel Gateway | |||
| RUN pip install git+https://github.com/jupyter-incubator/kernel_gateway.git | |||
| RUN pip install --no-cache-dir git+https://github.com/jupyter-incubator/kernel_gateway.git | |||
There was a problem hiding this comment.
Convert to straight pip install like the others - incubator is no longer required.
There was a problem hiding this comment.
Done as requested
| @@ -3,7 +3,7 @@ | |||
| FROM jupyter/all-spark-notebook:dbb9c7b50531 | |||
|
|
|||
| # Install Kernel Gateway | |||
| RUN pip install git+https://github.com/jupyter-incubator/kernel_gateway.git | |||
| RUN pip install --no-cache-dir git+https://github.com/jupyter-incubator/kernel_gateway.git | |||
There was a problem hiding this comment.
Done as requested
Rajpratik71
force-pushed
the
optimization/pip-no-cache
branch
from
c77f45e to
f64ee88
Compare
Some version restriction dropped and further Using "--no-cache-dir" flag in pip install ,make sure dowloaded packages by pip don't cached on system . This is a best practise which make sure to fetch ftom repo instead of using local cached one . Further , in case of Docker Containers , by restricing caching , we can reduce image size. In term of stats , it depends upon the number of python packages multiplied by their respective size . e.g for heavy packages with a lot of dependencies it reduce a lot by don't caching pip packages. Further , more detail information can be found at https://medium.com/sciforce/strategies-of-docker-images-optimization-2ca9cc5719b6
Rajpratik71
force-pushed
the
optimization/pip-no-cache
branch
from
f64ee88 to
f15a9a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using "--no-cache-dir" flag in pip install ,make sure dowloaded packages
by pip don't cached on system . This is a best practise which make sure
to fetch ftom repo instead of using local cached one . Further , in case
of Docker Containers , by restricing caching , we can reduce image size.
In term of stats , it depends upon the number of python packages
multiplied by their respective size . e.g for heavy packages with a lot
of dependencies it reduce a lot by don't caching pip packages.
Further , more detail information can be found at
https://medium.com/sciforce/strategies-of-docker-images-optimization-2ca9cc5719b6