Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown_all does not check VALIDATE_KG_CERT #42

Merged
merged 1 commit into from
May 12, 2017

Conversation

chuyqa
Copy link
Contributor

@chuyqa chuyqa commented Feb 17, 2017

When shutting down a notebook after shutdown_all has been called, the following is thrown:
[W 12:31:06.868 NotebookApp] SSL Error on 10 ('x.x.x.x', 8443): [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:765)

This adds the same validate_cert logic to shutdown_all which is used for fetch_kg

When shutting down a notebook after shutdown_all has been called, the following is thrown:
[W 12:31:06.868 NotebookApp] SSL Error on 10 ('x.x.x.x', 8443): [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:765)

This adds the same validate_cert logic to shutdown_all which is used for fetch_kg
@parente parente merged commit dd76bea into jupyter:master May 12, 2017
@parente
Copy link
Member

parente commented May 12, 2017

Sorry for the long delay. I think I'm not getting notifications for this repo. I'll check my settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants