Clarify what a restart means #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
LGTM. Thanks, @mlucool! Let's wait to merge this until we settle jupyter/enhancement-proposals#118 (comment)?
minrk
reviewed
Sep 2, 2023
docs/messaging.rst
Outdated
| possible (e.g. only restart the kernel and its subprocesses and not any | ||
| parent processes). That is, ideally a restart should be "in-place". For local | ||
| kernels, there is typically no parent process so a "hard" restart and an in-place | ||
| restart are identical whereas for remote kernels this is not generally the same. |
There was a problem hiding this comment.
Great! Maybe worth giving an example, e.g. for a kernel running a container, the container may be kept running and a new kernel process started in the same container without restarting the container. It may also be worth making clear that this is a note for the code starting kernels, since most docs here are about how the kernel should respond to messages.
There was a problem hiding this comment.
Thoughts on the new wording?
minrk
approved these changes
Sep 26, 2023
|
@minrk @Zsailer can this be merged given jupyter/enhancement-proposals#118? |
|
Yes. Thank you @mlucool for your work here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending jupyter/enhancement-proposals#118 being accepted