Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more coverage #877

Merged
merged 37 commits into from
Nov 15, 2022
Merged

Add more coverage #877

merged 37 commits into from
Nov 15, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Nov 12, 2022

  • Add coverage for JupyterConsoleApp, with attempted ssh tunneling. Skip checking ssh/forward.py since it isn't used and is listed as a demo.
  • Add coverage for the kernel spec apps
  • Increase Session coverage
  • Increase localinterfaces coverage
  • Increase KernelClient coverage
  • Add Windows coverage

@blink1073 blink1073 merged commit 7e7c286 into jupyter:main Nov 15, 2022
@blink1073 blink1073 deleted the moar-coverage branch November 15, 2022 11:09
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request May 16, 2023
Deselect a failing test that seems to be inappropriately constructed.

This test is added in
jupyter/jupyter_client#877.
Its code is not platform dependent but upstream claims that it
only works with cpython on ubuntu in ci.

Close felixonmars#2519
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request May 16, 2023
Deselect a failing test that seems to be inappropriately constructed.

This test is added in
jupyter/jupyter_client#877.
Its code is not platform dependent but upstream claims that it
only works with cpython on ubuntu in ci.

Close #2519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant