Clean up types and remove use of entrypoints #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
force-pushed
the
update-types
branch
from
89b4753 to
6d2cd14
Compare
blink1073
force-pushed
the
update-types
branch
from
ef43529 to
ef605c4
Compare
kevin-bates
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
These changes look good @blink1073. I ran with remote-provisioners installed (and not installed) and got expected results.
I left a couple of very minor suggestions relative to some comments.
Thanks for dealing with this!
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entrypointshas been deprecated in favor ofimportlib.metadata.