Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asyncio error when opening notebooks #718

Closed
wants to merge 1 commit into from
Closed

Fix asyncio error when opening notebooks #718

wants to merge 1 commit into from

Commits on Nov 2, 2021

  1. Fix asyncio error when opening notebooks 

    This is a fix for jupyter/notebook#6164

We are only applying `nest_asyncio` when `run_sync` has been called
which means there could be tasks queued that are unpatched e.g. from
the original issue:

```
<Task pending coro=<HTTP1ServerConnection._server_request_loop() running at /apps/python3/lib/python3.7/site-packages/tornado/http1connection.py:823>
```
which originates from Tornado.

A similar issue was reported in `nest-asyncio`: erdewit/nest_asyncio#22
where the solution is to call `apply` on import so that unpatched tasks
do not get created.
    @dleen
    dleen committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    8f832ac View commit details
    Browse the repository at this point in the history