Fix up some async method aliases in KernelManager #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the 7.0 release, I was perusing the changes to
KernelManager
and noticed some "internal" methods (i.e., methods that won't typically be overridden and are called from within "public" methods) had been changed toasync
but didn't have a backward-compatible "non-async" alias. As a result, applications that subclassKernelManager
and override any of the following methods will not have their overrides called.pre_start_kernel()
post_start_kernel()
request_shutdown()
This pull request addresses this issue by introducing the appropriate aliasing thereby restoring the hierarchical call sequence.
Note that these methods were made
async
forAsyncKernelManager
, but that will be called out in the 7.0 release notes - along with the other changes.