BUG: Fix Kwarg only in update_env

closes jupyterlab/jupyterlab#15301
jupyter · Nov 6, 2023 · f8e8d7c · f8e8d7c
1 parent 79fa122
commit f8e8d7c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/jupyter_client/manager.py b/jupyter_client/manager.py
@@ -281,7 +281,8 @@ def update_env(self, *, env: t.Dict[str, str]) -> None:
 
         .. version-added: 8.5
         """
-        self._launch_args["env"].update(env)
+        if "env" in self._launch_args and isinstance(self._launch_args["env"], dict):
+            self._launch_args["env"].update(env)
 
     def format_kernel_cmd(self, extra_arguments: t.Optional[t.List[str]] = None) -> t.List[str]:
         """Replace templated args (e.g. {connection_file})"""

diff --git a/jupyter_client/multikernelmanager.py b/jupyter_client/multikernelmanager.py
@@ -223,7 +223,7 @@ def update_env(self, *, kernel_id: str, env: t.Dict[str, str]) -> None:
         .. version-added: 8.5
         """
         if kernel_id in self:
-            self._kernels[kernel_id].update_env(env)
+            self._kernels[kernel_id].update_env(env=env)
 
     async def _add_kernel_when_ready(
         self, kernel_id: str, km: KernelManager, kernel_awaitable: t.Awaitable