Merge pull request #420 from impact27/master

Make closing jupyter client faster

jupyter_client/channels.py

@@ -7,7 +7,7 @@
 
 import atexit
 import errno
-from threading import Thread
+from threading import Thread, Event
 import time
 
 import zmq
@@ -73,6 +73,7 @@ def __init__(self, context=None, session=None, address=None):
 
         # running is False until `.start()` is called
         self._running = False
+        self._exit = Event()
         # don't start paused
         self._pause = False
         self.poller = zmq.Poller()
@@ -138,7 +139,7 @@ def run(self):
         while self._running:
             if self._pause:
                 # just sleep, and skip the rest of the loop
-                time.sleep(self.time_to_dead)
+                self._exit.wait(self.time_to_dead)
                 continue
 
             since_last_heartbeat = 0.0
@@ -154,7 +155,7 @@ def run(self):
                 # sleep the remainder of the cycle
                 remainder = self.time_to_dead - (time.time() - request_time)
                 if remainder > 0:
-                    time.sleep(remainder)
+                    self._exit.wait(remainder)
                 continue
             else:
                 # nothing was received within the time limit, signal heart failure
@@ -183,6 +184,7 @@ def is_beating(self):
     def stop(self):
         """Stop the channel's event loop and join its thread."""
         self._running = False
+        self._exit.set()
         self.join()
         self.close()