Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add r-htmltools pkg #573

Merged
merged 1 commit into from
Mar 14, 2018
Merged

add r-htmltools pkg #573

merged 1 commit into from
Mar 14, 2018

Conversation

terhorst
Copy link
Contributor

@terhorst terhorst commented Mar 9, 2018

This is another conda package which is required for some tidyverse functions (specifically, stringr::str_view) but not included in the r-tidyverse metapackage. (cf #532)

@parente
Copy link
Member

parente commented Mar 9, 2018

I think the build failure is related to the max build time allowed on Travis. I've opened #577 so we can address that problem separately.

I haven't had a lot of time recently to contribute to open source and don't look to have a lot coming up. That said, I don't want this PR to block waiting for the Travis fix. We can move ahead with merging it. If there is a true problem with the Docker image, it will simply fail to build on Docker Cloud and won't be available for people to use anyway.

If this sounds reasonable, let me know and I (or someone) can hit the merge button.

@parente parente merged commit ae51a60 into jupyter:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants