Fix Python version pin #2085
Merged
Fix Python version pin #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Jan 21, 2024
| @@ -117,7 +117,8 @@ RUN set -x && \ | |||
| 'jupyter_core' && \ | |||
| rm -rf /tmp/bin/ && \ | |||
| # Pin major.minor version of python | |||
| mamba list python | grep '^python ' | tr -s ' ' | cut -d ' ' -f 1,2 >> "${CONDA_DIR}/conda-meta/pinned" && \ | |||
| # https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-pkgs.html#preventing-packages-from-updating-pinning | |||
| mamba list --full-name 'python' | tail -1 | tr -s ' ' | cut -d ' ' -f 1,2 | sed 's/\.[^.]*$/.*/' >> "${CONDA_DIR}/conda-meta/pinned" && \ | |||
There was a problem hiding this comment.
I simplified a little bit the command here, --full-name is exactly what we need.
I used sed command from @ehfd issue: #2084 (comment), but removed extra space it was adding there.
mathbunnyru
commented
Jan 21, 2024
| @@ -117,7 +117,8 @@ RUN set -x && \ | |||
| 'jupyter_core' && \ | |||
| rm -rf /tmp/bin/ && \ | |||
| # Pin major.minor version of python | |||
| mamba list python | grep '^python ' | tr -s ' ' | cut -d ' ' -f 1,2 >> "${CONDA_DIR}/conda-meta/pinned" && \ | |||
| # https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-pkgs.html#preventing-packages-from-updating-pinning | |||
There was a problem hiding this comment.
Future contributors will be happy to see it's an official and recommended way of pinning packages.
max-muoto
pushed a commit
to max-muoto/docker-stacks
that referenced
this pull request
Mar 10, 2024
max-muoto
pushed a commit
to max-muoto/docker-stacks
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Fix: #2084
Checklist (especially for first-time contributors)