Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing docs to GitHub Actions #1239

Merged
merged 9 commits into from
Apr 13, 2021

Conversation

trallard
Copy link
Member

This PR updates the contributing stack documentation to sync with the use of GitHub actions instead of Travis.

closes #1139

@trallard trallard marked this pull request as draft February 18, 2021 13:30
@trallard trallard changed the title [WIP] - Update contributing docs to GitHub actions [WIP] - Update contributing docs to GitHub Actions Feb 18, 2021
@trallard trallard marked this pull request as ready for review April 5, 2021 09:20
@trallard trallard changed the title [WIP] - Update contributing docs to GitHub Actions Update contributing docs to GitHub Actions Apr 5, 2021
@trallard
Copy link
Member Author

trallard commented Apr 5, 2021

This PR is ready for review now and complements the PR in the cookiecutter repo

@romainx
Copy link
Collaborator

romainx commented Apr 8, 2021

@trallard thanks for this work, sorry I'm a bit overloaded at this time, what do you think if I try to work on it (meaning this PR and its counterpart in the other repo) this WE?

@trallard
Copy link
Member Author

trallard commented Apr 8, 2021

Sure @romainx, there is no rush. I know how busy things can get.

Copy link
Collaborator

@romainx romainx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @trallard,

As we have merged jupyter/cookiecutter-docker-stacks#5 we can merge it as well. I let you a small remark related to main and master branches.

Once fixed we will be able to merge it.

Many thanks for that !!

docs/contributing/stacks.md Show resolved Hide resolved
docs/contributing/stacks.md Outdated Show resolved Hide resolved
Copy link
Member

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great job. Added some small notes.

docs/contributing/stacks.md Outdated Show resolved Hide resolved
docs/contributing/stacks.md Outdated Show resolved Hide resolved
docs/contributing/stacks.md Outdated Show resolved Hide resolved
trallard and others added 5 commits April 13, 2021 11:08
Co-authored-by: Romain <romainx@users.noreply.github.com>
Co-authored-by: Romain <romainx@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
@trallard
Copy link
Member Author

Thanks for the review folks! I have committed the changes and fixed some additional typos/grammatical stuff. This should be ready now

Copy link
Member

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🔥

@romainx romainx merged commit 022e517 into jupyter:master Apr 13, 2021
@romainx
Copy link
Collaborator

romainx commented Apr 13, 2021

Great thank you !! A looooonnnnng standing action is closed 🎉

@trallard trallard deleted the feature/gh-actions-docs branch February 16, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cookiecutter-docker-stacks
3 participants