-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing docs to GitHub Actions #1239
Conversation
GH Actions replaces Travis
This PR is ready for review now and complements the PR in the cookiecutter repo |
@trallard thanks for this work, sorry I'm a bit overloaded at this time, what do you think if I try to work on it (meaning this PR and its counterpart in the other repo) this WE? |
Sure @romainx, there is no rush. I know how busy things can get. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @trallard,
As we have merged jupyter/cookiecutter-docker-stacks#5 we can merge it as well. I let you a small remark related to main
and master
branches.
Once fixed we will be able to merge it.
Many thanks for that !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great job. Added some small notes.
Co-authored-by: Romain <romainx@users.noreply.github.com>
Co-authored-by: Romain <romainx@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Thanks for the review folks! I have committed the changes and fixed some additional typos/grammatical stuff. This should be ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🔥
Great thank you !! A looooonnnnng standing action is closed 🎉 |
This PR updates the contributing stack documentation to sync with the use of GitHub actions instead of Travis.
closes #1139