Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .dockerignore by adding default hooks + test dirs #1201

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

romainx
Copy link
Collaborator

@romainx romainx commented Dec 20, 2020

Hello,

Just figured out that standards hooks and test directories that are part of most of the Docker image's folder were not included in the .dockerignore.
It's not a big improvement but they will not be anymore send to the daemon now.

Best

@romainx romainx added the type:Enhancement A proposed enhancement to the docker images label Dec 20, 2020
@romainx
Copy link
Collaborator Author

romainx commented Dec 20, 2020

Since is a straightforward and non user-facing change, I'm merging it directly.

Best.

@romainx romainx merged commit a0a544e into jupyter:master Dec 20, 2020
@romainx romainx deleted the fix_dockerignore branch December 20, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant