Skip to content

Commit

Permalink
Merge pull request #1750 from mathbunnyru/asalikhov/reduce_timeouts
Browse files Browse the repository at this point in the history
Reduce sleep timeouts in tests
  • Loading branch information
mathbunnyru authored Jul 17, 2022
2 parents 20dcf41 + 6e62efb commit 9b3c3b1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions tests/base-notebook/test_container_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def test_unsigned_ssl(
# properly while the server is booting up. An SSL handshake error seems to
# abort the retry logic. Forcing a long sleep for the moment until I have
# time to dig more.
time.sleep(5)
time.sleep(1)
resp = http_client.get(f"https://localhost:{host_port}", verify=False)
resp.raise_for_status()
assert "login_submit" in resp.text
Expand Down Expand Up @@ -91,9 +91,9 @@ def test_nb_user_change(container: TrackedContainer) -> None:
command=["start.sh", "bash", "-c", "sleep infinity"],
)

# Give the chown time to complete. Use sleep, not wait, because the
# container sleeps forever.
time.sleep(10)
# Give the chown time to complete.
# Use sleep, not wait, because the container sleeps forever.
time.sleep(1)
LOGGER.info(f"Checking if the user is changed to {nb_user} by the start script ...")
output = running_container.logs().decode("utf-8")
assert "ERROR" not in output
Expand Down
2 changes: 1 addition & 1 deletion tests/base-notebook/test_start_container.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def test_start_notebook(
ports={"8888/tcp": host_port},
)
# sleeping some time to let the server start
time.sleep(3)
time.sleep(1)
logs = running_container.logs().decode("utf-8")
LOGGER.debug(logs)
# checking that the expected command is launched
Expand Down

0 comments on commit 9b3c3b1

Please sign in to comment.