Skip to content

Commit

Permalink
Better codestyle
Browse files Browse the repository at this point in the history
  • Loading branch information
@mathbunnyru
mathbunnyru committed Nov 15, 2022
1 parent 1e6f34d commit 6cc4a85
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions tagging/merge_tags.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,7 @@ def merge_tags(
)

LOGGER.info(f"Found images: {existing_images}")
(
docker[
"manifest",
"create",
tag,
][existing_images]
& plumbum.FG
)
docker["manifest", "create", tag][existing_images] & plumbum.FG
docker["manifest", "push", tag] & plumbum.FG


Expand Down

2 comments on commit 6cc4a85

@bjornjorgensen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you changed her seems to be Black formated.

BTW I have enabled sonarcloud and Remove or refactor this statement; it has no side effects.

@mathbunnyru
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how Black formatted, when there was a trailing comma. In this case I think it's better to use one line, because then next line is very similar.

This statement has a side effect, I think sonar cloud is not happy about about plumbum (I have no idea why).

Please sign in to comment.