This repository has been archived by the owner on Oct 26, 2019. It is now read-only.
[Issue 3] - Added support for https #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(c) Copyright IBM Corp. 2016
| debug('Using, HTTPS_KEY_FILE = ' + key_file_location); | ||
| debug('Using, HTTPS_CERT_FILE = ' + cert_file_location); | ||
| debug('Server set to HTTPS mode'); | ||
| } else { |
There was a problem hiding this comment.
If the vars are set, but the paths are invalid, I think an exception should be thrown. Otherwise, a user might think he/she has things setup to be secure, but wind up running an insecure HTTP server instead
(c) Copyright IBM Corp. 2016
poplav
force-pushed
the
issue-3-support-https
branch
from
2e243c7
to
e9dcbf4
Compare
Closed
parente
changed the title
jhpedemonte
added a commit
that referenced
this pull request
Jan 20, 2016
[Issue 3] - Added support for https
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(c) Copyright IBM Corp. 2016