Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating context creation in the exemple #413

Merged
merged 2 commits into from
Dec 17, 2024
Merged

updating context creation in the exemple #413

merged 2 commits into from
Dec 17, 2024

Conversation

SandrineP
Copy link
Contributor

No description provided.

anutosh491
anutosh491 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, except 1 thing which is on line 34 we should use make_xserver_default rather than make_xserver_zmq.

The latter was dropped after updating xeus-zmq to 3.0. Thanks !

@JohanMabille
Copy link
Member

Good catch!

@SandrineP
Copy link
Contributor Author

Thanks @anutosh491, I made the change.

@JohanMabille JohanMabille merged commit d1a9fa4 into jupyter-xeus:main Dec 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anutosh491 anutosh491 anutosh491 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SandrineP @JohanMabille @anutosh491