Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return to pack_models #3923

Merged
merged 1 commit into from
May 28, 2024
Merged

Add return to pack_models #3923

merged 1 commit into from
May 28, 2024

Conversation

gjmooney
Copy link
Contributor

Add a return for packed in pack_models . @martinRenou

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a binder notebook on branch gjmooney/ipywidgets/add_return_to_pack_models

@gjmooney gjmooney marked this pull request as ready for review May 28, 2024 08:06
martinRenou
martinRenou approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a longstanding issue on the widget serialization logic front-end side. It looks like it's not well tasted nor used in custom widgets.

@martinRenou
Copy link
Member

Thanks @gjmooney !!

@martinRenou martinRenou merged commit e8a4cb8 into jupyter-widgets:main May 28, 2024
21 checks passed
@Zalnd Zalnd mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmooney @martinRenou