Fix Item ordering in 'Select*', 'ToggleButtons' and 'RadioButtons' widgets #1192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1191.
I'm not sure if you are still accepting pull requests for bugs on the 5.x branch, but given jupyter/dashboards_server#317 I still need ipywidgets 5.x, so thought I would make this change available upstream.
I essentially change the logic to be more inline with that on the current
master
branch (example),where instead of updating the DOM with elements and then deleting any which are no longer present, we instead rebuild the list of DOM elements from scratch.
Now elements in the DOM respect the ordering of elements in the
options
of the model.