Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Item ordering in 'Select*', 'ToggleButtons' and 'RadioButtons' widgets #1192

Closed
wants to merge 3 commits into from

Conversation

jbweston
Copy link
Member

@jbweston jbweston commented Mar 7, 2017

Fixes #1191.

I'm not sure if you are still accepting pull requests for bugs on the 5.x branch, but given jupyter/dashboards_server#317 I still need ipywidgets 5.x, so thought I would make this change available upstream.

I essentially change the logic to be more inline with that on the current master branch (example),
where instead of updating the DOM with elements and then deleting any which are no longer present, we instead rebuild the list of DOM elements from scratch.

Now elements in the DOM respect the ordering of elements in the options of the model.

@jasongrout jasongrout added this to the 5.x milestone Mar 15, 2017
@jasongrout
Copy link
Member

Thanks! I'm not sure if we'll be releasing another 5.x release, but this will be in it if we do.

@jasongrout
Copy link
Member

jasongrout commented Jul 6, 2018

Since we now are on ipywidgets version 7, we don't plan any more 5.x releases. Thanks again for your work on this. The dashboards server is now longer active either.

@jasongrout jasongrout closed this Jul 6, 2018
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants